-
Notifications
You must be signed in to change notification settings - Fork 64
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
refactor: removing module federation-based plugins
The code removed in this commit existed to load plugins via webpack module federation. It was never intended to be included in this version of plugins. We don’t intend to use module federation, and are instead investing in a micro-frontend framework like Piral.
- Loading branch information
Showing
7 changed files
with
8 additions
and
129 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,12 +1,12 @@ | ||
/* eslint-disable import/prefer-default-export */ | ||
import PropTypes from 'prop-types'; | ||
import { COMPONENT_PLUGIN, IFRAME_PLUGIN } from './constants'; | ||
import { IFRAME_PLUGIN } from './constants'; | ||
|
||
export const pluginShape = PropTypes.shape({ | ||
scope: PropTypes.string, | ||
module: PropTypes.string, | ||
url: PropTypes.string.isRequired, | ||
type: PropTypes.oneOf([COMPONENT_PLUGIN, IFRAME_PLUGIN]).isRequired, | ||
type: PropTypes.oneOf([IFRAME_PLUGIN]).isRequired, | ||
// This is a place for us to put any generic props we want to pass to the component. We need it. | ||
props: PropTypes.object, // eslint-disable-line react/forbid-prop-types | ||
}); |
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters