-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: post translation validation errors as a GitHub comment | FC-0012 #1894
Conversation
Thanks for the pull request, @OmarIthawi! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
6803c8b
to
f548f2f
Compare
✅ All translation files are valid. This comment has been posted by the |
88cfc94
to
90bc72e
Compare
90bc72e
to
56fc636
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
neat! I like it. Thank you @OmarIthawi
@OmarIthawi 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
Problem
Locating the validation error can be difficult in the GitHub Actions check.
Solution
Post a comment (e.g. #1894 (comment)) in the pull request with failed translations.
The comments are "sticky" to avoid spamming the pull requests with multiple comments.
Limitation: forks no supported
This won't affect us because bots writes directly to this repository.
Testing results
Testing results with screenshots
References
This contribution is part of the FC-0012 project which is sparked by the Translation Infrastructure update OEP-58.