-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add openedx-app-ios with support for pre-extract step | FC-55 #6068
Conversation
Thanks for the pull request, @OmarIthawi! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
{ | ||
repo: 'openedx-app-ios', | ||
transifex_file_path: 'I18N/en.lproj/Localizable.strings', | ||
before_extract: 'make translation_requirements', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@brian-smith-tcril I'd like your opinion here.
The pull request is ready for merge once the iOS PR is merged.
@Amr-Nash please checkout this pull request and let me know if all is okay. |
Closing in favor of #6394 |
@OmarIthawi Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future. |
Changes
before_translate
step.TODO
Refs
This pull request is part of the FC-0055 project which implements the Translation Infrastructure update OEP-58 for mobile apps.