Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add openedx-app-ios with support for pre-extract step | FC-55 #6068

Closed
wants to merge 1 commit into from

Conversation

OmarIthawi
Copy link
Member

@OmarIthawi OmarIthawi commented May 16, 2024

Changes

TODO

Refs

This pull request is part of the FC-0055 project which implements the Translation Infrastructure update OEP-58 for mobile apps.

@openedx-webhooks
Copy link

openedx-webhooks commented May 16, 2024

Thanks for the pull request, @OmarIthawi! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label May 16, 2024
@OmarIthawi OmarIthawi changed the title chore: add openedx-app-ios with support for optional translation_requirements.txt | FC-55 chore: add openedx-app-ios with support for pre-extract step May 18, 2024
@OmarIthawi OmarIthawi changed the title chore: add openedx-app-ios with support for pre-extract step chore: add openedx-app-ios with support for pre-extract step | FC-55 May 18, 2024
{
repo: 'openedx-app-ios',
transifex_file_path: 'I18N/en.lproj/Localizable.strings',
before_extract: 'make translation_requirements',
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@brian-smith-tcril I'd like your opinion here.

The pull request is ready for merge once the iOS PR is merged.

@OmarIthawi
Copy link
Member Author

@Amr-Nash please checkout this pull request and let me know if all is okay.

@OmarIthawi OmarIthawi changed the title chore: add openedx-app-ios with support for pre-extract step | FC-55 feat: add openedx-app-ios with support for pre-extract step | FC-55 May 18, 2024
@OmarIthawi OmarIthawi marked this pull request as ready for review June 13, 2024 06:59
@OmarIthawi
Copy link
Member Author

Closing in favor of #6394

@OmarIthawi OmarIthawi closed this Jun 13, 2024
@openedx-webhooks
Copy link

@OmarIthawi Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants