Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add openedx-app-ios with support for pre-extract step | FC-55 #6068

Closed
wants to merge 1 commit into from
Closed

feat: add openedx-app-ios with support for pre-extract step | FC-55 #6068

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion .github/workflows/extract-translation-source-files.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,12 @@ jobs:
const allGenericRepos = [
{
repo: 'tutor-contrib-aspects',
transifex_file_path: 'transifex_input.yaml'
transifex_file_path: 'transifex_input.yaml',
},
{
repo: 'openedx-app-ios',
transifex_file_path: 'I18N/I18N/en.lproj/Localizable.strings',
before_extract: 'make translation_requirements',
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@brian-smith-tcril I'd like your opinion here.

The pull request is ready for merge once the iOS PR is merged.

},
]

Expand Down Expand Up @@ -417,6 +422,13 @@ jobs:
- name: install requirements
run: pip install -r requirements/translations.txt

- name: run optional pre-extraction step
if: "${{ matrix.repository_config.before_extract }}"
run: |
# If the repository has additional requirements or processing steps run them
cd translations/${{ matrix.repository_config.repo }}
${{ matrix.repository_config.before_extract }}

# Extracts the translation source files
- name: extract translation source files
run: |
Expand Down
8 changes: 8 additions & 0 deletions transifex.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -296,6 +296,14 @@ git:
source_file_dir: translations/platform-plugin-aspects/platform_plugin_aspects/conf/locale/en/
translation_files_expression: 'translations/platform-plugin-aspects/platform_plugin_aspects/conf/locale/<lang>/'

# openedx-app-ios
- filter_type: file
file_format: STRINGS
source_file_extension: strings
source_language: en
source_file_dir: translations/openedx-app-ios/I18N/I18N/en.lproj/Localizable.strings
translation_files_expression: 'translations/openedx-app-ios/I18N/I18N/<lang>.lproj/Localizable.strings'

# RecommenderXBlock
- filter_type: dir
file_format: PO
Expand Down
Loading