refactor: Move translations to the openedx Transifex project #462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The double curly braces breaks YAML, and we don't want to be translating the rendered files as currently happens. We'll need to update this functionality to pull what data it can at runtime.
Ian2012
approved these changes
Oct 12, 2023
Per feedback in openedx/openedx-translations#1834 this is really just a temp file, so we should treat it as one. Also adding a README to the locale dir to deter people from editing those files.
Now we're running out of space on those test runners as well.
|
@Ian2012 made a couple of changes based on feedback and to fix tests. Want to take another look? |
|
Amazing! Thanks for pushing on this front :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tries to get us in line with OEP-58 and using openedx-translations / Atlas to manage the translation files. It's very likely going to require some iteration to get everything working correctly, but we can't do that until this lands since we need to get some actual translation files in Transifex to work with. So consider this part one of at least two.
Will need openedx/openedx-translations#1834 to land to be functional as well, so I'm awaiting feedback on that before merging.
Partially solves: #435