Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Added Contextual Tuples to Assertions #157

Merged
merged 2 commits into from
May 9, 2024
Merged

feat: Added Contextual Tuples to Assertions #157

merged 2 commits into from
May 9, 2024

Conversation

smeadows-okta
Copy link
Contributor

@smeadows-okta smeadows-okta commented May 9, 2024 •
edited by jon-whit
Loading

Added support for contextual tuple to assertions

Description

Currently, assertions are pure (object, relation, subject) tuples. Added support for contextual tuples to assertions for advanced scenarios.

References

openfga/openfga#946

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

@smeadows-okta smeadows-okta requested review from a team as code owners May 9, 2024 15:30
@smeadows-okta smeadows-okta marked this pull request as draft May 9, 2024 15:45
@smeadows-okta smeadows-okta marked this pull request as ready for review May 9, 2024 17:19
@smeadows-okta smeadows-okta merged commit 367d93b into main May 9, 2024
7 checks passed
@smeadows-okta smeadows-okta deleted the 946-support-contextual-tuples-in-assertions-api branch May 9, 2024 17:26
@jon-whit jon-whit mentioned this pull request May 21, 2024
Closed
4 tasks
@smeadows-okta smeadows-okta mentioned this pull request May 21, 2024
Closed
4 tasks
@smeadows-okta smeadows-okta changed the title Added Contextual Tuples to Assertions feat: Added Contextual Tuples to Assertions May 21, 2024
willvedd added a commit that referenced this pull request May 29, 2024
@willvedd
Reverting #157
1018b73
@willvedd willvedd mentioned this pull request May 29, 2024
Merged
4 tasks
jon-whit pushed a commit that referenced this pull request May 29, 2024
@willvedd
Reverting contextual tuples in assertions API (#157) (#167)
5b0b494
miparnisari added a commit that referenced this pull request Aug 6, 2024
@miparnisari
Revert "Reverting contextual tuples in assertions API (#157) (#167)"
d53ea84 
This reverts commit 5b0b494.
@miparnisari miparnisari mentioned this pull request Aug 6, 2024
Merged
miparnisari added a commit that referenced this pull request Aug 7, 2024
@miparnisari
feat: add support for contextual tuples in assertions API (#185)
c96ec77 
* Revert "Reverting contextual tuples in assertions API (#157) (#167)"

This reverts commit 5b0b494.

* undo go.mod changes

* amend API descriptions

* run make

* apply suggestion
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miparnisari miparnisari miparnisari approved these changes

@rhamzeh rhamzeh rhamzeh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@smeadows-okta @rhamzeh @miparnisari