Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SCimilarity #2

Closed

Conversation

lazappi
Copy link
Contributor

@lazappi lazappi commented Oct 2, 2024

Describe your changes

Add SCimilarity as a method. Requires adding a new test dataset as SCimilarity can only be run on human data.

Checklist before requesting a review

  • I have performed a self-review of my code

  • Check the correct box. Does this PR contain:

    • Breaking changes
    • New functionality
    • Major changes
    • Minor changes
    • Bug fixes
  • Proposed changes are described in the CHANGELOG.md

  • CI Tests succeed and look good!

@lazappi
Copy link
Contributor Author

lazappi commented Oct 2, 2024

@rcannood I am relatively confident the component works but we need to work out how to handle the model input. At the moment the component tests fail because there is no example file and they model is not downloaded anywhere.

Copy link
Member

@rcannood rcannood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comments

@@ -26,6 +26,7 @@ methods = [
scalex,
scanorama,
scanvi,
scimilarity,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can add a value for model here

Suggested change
scimilarity,
scimilarity.run(
args: [model: file("https://path/to/model")]
),

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't quite work, you get ERROR ~ No such variable: scimilarity from Nextflow (I guess because it's not defined yet)

scripts/create_resources/test_resources.sh Outdated Show resolved Hide resolved
Copy link
Member

@rcannood rcannood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this could be used to not let the CI run the scimilarity unit test for now:

src/api/base_method.yaml:

namespace: methods
info:
  type: method
  type_info:
    label: Method
    summary: A method for the batch integration task.
    description: |
      A batch integration method which integrates multiple datasets.
arguments:
  - name: --input
    __merge__: file_dataset.yaml
    direction: input
    required: true
  - name: --output
    __merge__: file_integrated.yaml
    direction: output
    required: true
test_resources:
  - type: python_script
    path: /common/component_tests/check_config.py

src/api/comp_method.yaml:

__merge__: base_method.yaml
test_resources:
  - type: python_script
    path: /common/component_tests/run_and_check_output.py
  - path: /resources_test/task_batch_integration/cxg_mouse_pancreas_atlas
    dest: resources_test/task_batch_integration/cxg_mouse_pancreas_atlas

@lazappi lazappi mentioned this pull request Oct 11, 2024
8 tasks
@lazappi
Copy link
Contributor Author

lazappi commented Oct 11, 2024

Replaced by #3

@lazappi lazappi closed this Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants