Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SCimilarity #3

Merged
merged 13 commits into from
Oct 22, 2024
Merged

Add SCimilarity #3

merged 13 commits into from
Oct 22, 2024

Conversation

lazappi
Copy link
Contributor

@lazappi lazappi commented Oct 11, 2024

Describe your changes>

Add SCimilarity as a method. Requires replacing the test dataset as SCimilarity can only be run on human data.

Replaces #2

Checklist before requesting a review

  • I have performed a self-review of my code

  • Check the correct box. Does this PR contain:

    • Breaking changes
    • New functionality
    • Major changes
    • Minor changes
    • Bug fixes

  • Proposed changes are described in the CHANGELOG.md

  • CI Tests succeed and look good!

@lazappi lazappi mentioned this pull request Oct 11, 2024
Closed
8 tasks
rcannood
rcannood approved these changes Oct 12, 2024
View reviewed changes
Copy link
Member

@rcannood rcannood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

rcannood
rcannood approved these changes Oct 21, 2024
View reviewed changes
Copy link
Member

@rcannood rcannood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved!

@rcannood rcannood merged commit 0149793 into main Oct 22, 2024
34 checks passed
@rcannood rcannood deleted the feature/no-ref/add-SCimilarity branch October 22, 2024 12:37
lazappi added a commit that referenced this pull request Oct 23, 2024
@lazappi
Merge remote-tracking branch 'origin/main' into feature/no-ref/add-Ge…
1e7dfa0 
…neformer

* origin/main:
  Add arguments for filtering methods in benchmark workflow (#4)
  Add SCimilarity (#3)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rcannood rcannood rcannood approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lazappi @rcannood