Cleaned up commandline arguments #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,4 +1,4 @@ | |||
| #!/usr/bin/env python | |||
| #!/usr/bin/env python3 | |||
There was a problem hiding this comment.
Maybe too bold?
I did it impulsively but now feeling like it defeats the point of writing all this 2+3 compatible code.
There was a problem hiding this comment.
Yea, works for me since I mainly use 3, but I think most still don't. Many academic cluster users won't have much of a choice on this and the netmhc tools require py2 so you'd need both installed.
|
Looks good! minor comments |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Every group of arguments now has its own package, which contains a function that adds arguments to a parser and helpers for using the argument values. This lets us repurpose subsets of Topiary's CLI for other libraries (like vaxrank).
Also added some column filtering and rename options for output files (since at least one user wants a custom output format: #56)
This change is