Skip to content

Update Python package #177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

kant2002
Copy link

Update code to work with latest Pandas.
Tested on Python 3.12, but from what I understand should works anywhere where Pandas is working.
Improve a bit testing scripts so they can be run from any location. For example, I use pipenv run py tests/tests.py.
Add pyproject.toml

Give somebody else pleasure to create LICENSE file, since I'm not aware who I should put there.

There two nagging warnings left


openworm\tracker-commons\src\Python\tests\..\wcon\wcon_data.py:496: FutureWarning: Setting an item of incompatible dtype is deprecated and will raise in a future error of pandas. Value '[2.]' has dtype incompatible with Int64, please explicitly cast to a compatible dtype first.
  df_odict[worm_id].loc[:, idx[:, 'aspect_size', :]] = \
openworm\tracker-commons\src\Python\tests\..\wcon\wcon_data.py:224: FutureWarning: Setting an item of incompatible dtype is deprecated and will raise in a future error of pandas. Value '[3.]' has dtype incompatible with Int64, please explicitly cast to a compatible dtype first.

That's from columns x and y being Int64 instead of Float64.

The only dependency which was "broken" was scipy which require having shim
There some warnings, which indicate that we incorrectly handle missing data, but for now they seems to be harmless.
@kant2002
Copy link
Author

Ooh, I realize that there was development branch where you have partially done things. Is there some conventions for repositories, I getting accustomed to always green main branch on different OSS projects so never looking what's else can be except home page.

@pgleeson
Copy link
Member

Sorry, it's often different and not usually documented with the various openworm repos, so it's usually best to look at the network view, for what's happenning in the branches here and in anyone else's: https://github.com/openworm/tracker-commons/network
My personal preference is to keep the main/master branch stable, have the latest working code in development, and make regular pull requests into there for issues/fixes. Here, I was just trying a few changes in the experimental branch, as there have been many py releases since this was all touched. It would be great if you could look in there if there are useful changes and see if the github actions tests can pass on multiple python versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants