Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated resampling resolution comparison #112

Open
wants to merge 11 commits into
base: dswx-ni-beta-point
Choose a base branch
from

Conversation

hb6688
Copy link
Contributor

@hb6688 hb6688 commented Nov 7, 2024

Major Updates:

  1. Added comments.
  2. Updated following scripts:
    1. dswx_ni_runconfig.py
    2. mosaic_gcov_frame.py

Updated functions in dswx_ni_runconfig.py

  1. get_freq_rtc_hdf5
  2. get_res_rtc_hdf5
  3. get_pol_rtc_hdf5
  4. get_freq_rtc_hdf5
  5. check_rtc_frequency
  6. read_rtc_polarization
  7. read_rtc_resolution
  8. compare_rtc_resolution (will remove after review)
  9. compare_rtc_polariztion
  10. verify_nisar_mode

Updated schema and configuration file:

  1. removed resamp_required parameter. It is now determined in dswx_ni_runconfig.py
  2. resamp_out_res is dependent on highest resolution of all inputs

@@ -1012,8 +1014,14 @@ def run(cfg):
mosaic_cfg = processing_cfg.mosaic
mosaic_mode = mosaic_cfg.mosaic_mode
mosaic_prefix = mosaic_cfg.mosaic_prefix
nisar_uni_mode = processing_cfg.nisar_uni_mode

# Determine if resampling is required
Copy link
Contributor

@oberonia78 oberonia78 Nov 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hb6688 I hope you add more descriptions. nisar_uni_mode and resamp_required, and resamp_out_res are determined from dswx_ni_runconfig.py, not from user. I think this should be clarified and mentioned here.

Copy link
Contributor

@oberonia78 oberonia78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we've already discussed about the logic to mosaic the images when two RTCs have different spacing and modes, I understand why you implemented like this. However, I hope you add more explanation in the script. It would be easier to read and follow in future when we find the issue.

@oberonia78 oberonia78 mentioned this pull request Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants