Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add HEBO sampler supporting Define-by-Run manner, maximization, parallelization, and constant_liar #195
Add HEBO sampler supporting Define-by-Run manner, maximization, parallelization, and constant_liar #195
Changes from 6 commits
0aafcc7
3f5df46
4a8806d
4417a72
8da9640
11f1cff
1f28f09
06c61c6
3e7e132
fca0635
7839195
28b592e
c26ae72
96e8246
f4d5aa0
b714476
b03272b
3d5d664
309717f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about using hebo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the exact same code as the preceding HEBO package, so I would prefer to maintain it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be better to use
hebo.suggest
even if we do not have completed trials, becausehebo.suggest
uses qmc if I remember correctly.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This sampler does not call
hebo.suggest()
here because it needs to know search space by running the first trial.(It uses
BaseSampler
, so search space is not given.)I have added comment about this in the code.