feat: support deletion for memory resolver #607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wangxiaoxuan273
requested review from
sajayantony,
shizhMSFT,
SteveLasker and
Wwwsylvia
as code owners
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## main #607 +/- ##
=======================================
Coverage 74.46% 74.47%
=======================================
Files 59 59
Lines 5275 5277 +2
=======================================
+ Hits 3928 3930 +2
Misses 993 993
Partials 354 354
|
Wwwsylvia
reviewed
Sep 25, 2023
Signed-off-by: Xiaoxuan Wang <[email protected]>
Signed-off-by: Xiaoxuan Wang <[email protected]>
wangxiaoxuan273
force-pushed
the
resolver
branch
from
16a1ae6 to
50caeb4
Compare
shizhMSFT
pushed a commit
that referenced
this pull request
Nov 20, 2023
Part 4/4 of #454 This PR should be reviewed and merged after PR #606 #607 #608 --------- Signed-off-by: Xiaoxuan Wang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part 2/4 of #454
Based on draft PR #582