Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove top module auto-detect indication for simulation #1664

Merged
merged 2 commits into from
Jul 25, 2024

Conversation

volodymyrkochyn
Copy link
Collaborator

Motivate of the pull request

  • To address an existing issue. If so, please provide a link to the issue:
  • Breaking new feature. If so, please describe details in the description part.

Describe the technical details

Remove top module auto-detect indication for simulation. No other changes regarding auto-detect feature.

Simulation:
image

Design:
image

Which part of the code base require a change

  • Library: newproject
  • Plug-in:
  • Engine
  • Documentation
  • Regression tests
  • Continous Integration (CI) scripts

Copy link

codecov bot commented Jul 25, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 14.64%. Comparing base (dff79d3) to head (c0b7e45).
Report is 48 commits behind head on main.

Files with missing lines Patch % Lines
src/NewProject/add_source_form.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1664      +/-   ##
==========================================
- Coverage   14.64%   14.64%   -0.01%     
==========================================
  Files         478      478              
  Lines       63616    63617       +1     
  Branches    25930    25992      +62     
==========================================
  Hits         9319     9319              
- Misses      53105    53113       +8     
+ Partials     1192     1185       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alaindargelas alaindargelas merged commit cec91c0 into main Jul 25, 2024
34 of 35 checks passed
@alaindargelas alaindargelas deleted the bug/EDA-3087/simulation-auto-detect branch July 25, 2024 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants