Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for EDA-2752 #320

Merged
merged 2 commits into from
Apr 30, 2024
Merged

Fix for EDA-2752 #320

merged 2 commits into from
Apr 30, 2024

Conversation

awaisabbas006
Copy link
Collaborator

No description provided.

@awaisabbas006
Copy link
Collaborator Author

@thierryBesson

Before yosys did not infer any display(), but with latest update we can infer $print for display feature of Verilog. As we donot have any model on which $print can be mapped so I removed this cell in synth_rs. Please review the PR.

Copy link
Collaborator

@BessonThierry BessonThierry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

eventually you can rename the function into "remove_unsupported_cells" in case we may need to remove other cells than "print" in the future.

Copy link
Contributor

@alaindargelas alaindargelas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please consider renaming the function as per @BessonThierry's comment in another PR

@alaindargelas alaindargelas merged commit b5d1f83 into os-fpga:main Apr 30, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants