Add error message for illegal port connection to fix EDA-2834

[awaisabbas006]

No description provided.

[awaisabbas006]

@thierryBesson I have created a PR to add error message for illegal port connection, if an input port is connected to both I_BUF and other components, please review the PR.

[BessonThierry]

@awaisabbas006 I see two times "design -save original" and splitnets both called when entering in 'get_port_cell_relation' and then after calling 'get_port_cell_relation'.
Are the ones after calling 'get_port_cell_relation' necessary ? especially also because they change the netlist and the object on which 'get_port_cell_relation' built the 'in_2_cell' dictionnary ?

[awaisabbas006]

Hi @thierryBesson you are right, I wanted to make get_port_cell_relation() generic function that's why I used it there, however later I also need to call splitnets pass.

Please let me know if we should call splitnet only once?

[BessonThierry]

@awaisabbas006 theoritically a second call to "splitnet" should do nothing since everything has been already splitted. And the "design save original " should be done at the same level as the "design -load original" (not one in the fucntion and the other one outside the function).

[awaisabbas006]

@thierryBesson please review now, I indeed had one mistake in my previous commit, i.e., I did not load the original design before leaving the get_port_cell_relation() function. I now use only one splitnet call.

[awaisabbas006]

@thierryBesson BTW, Also review the error message is it correct or need some modification.

[BessonThierry]

it looks ok to me, Thanks.

[BessonThierry]

it looks ok to me, Thanks.