Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added a builtin nodelet manager to the server #47

Merged
merged 1 commit into from
Mar 8, 2014
Merged

Conversation

wjwwood
Copy link
Member

@wjwwood wjwwood commented Mar 6, 2014

All launch files now get the argument capability_server_nodelet_manager_name set to the name of the nodelet manager so that they may use it to load their nodelet's into.

Closes #42

@wjwwood wjwwood mentioned this pull request Mar 6, 2014
@wjwwood
Copy link
Member Author

wjwwood commented Mar 7, 2014

@dirk-thomas I can't figure out why this CI is failing, do you have any idea? I am getting this error:

terminate called after throwing an instance of 'pluginlib::LibraryLoadException'
  what():  rospack could not find the nodelet package containing nodelet::Nodelet

I am trying to run this launch file:

https://github.com/osrf/capabilities/blob/issue_42/src/capabilities/capability_server_nodelet_manager.launch

as part of the capability_server. This works for me locally, can you see anything wrong with my .travis.yml or my make coverage command which might lead to this?

@dirk-thomas
Copy link

pluginlib internal uses roslib API which executes rospack to find the libraries containing plugins. It basically run the following command:

rospack plugins --attrib=plugin nodelet

In your case I assume it does not find a single plugin and pluginlib signals that wrongly as an exception: https://github.com/ros/pluginlib/blob/groovy-devel/include/pluginlib/class_loader_imp.h#L185

Try to add a dummy plugin to your environment and I would assume the error goes away.

Now ticketed here: ros/pluginlib#22

@wjwwood
Copy link
Member Author

wjwwood commented Mar 8, 2014

Ok, thanks.

All launch files now get the argument
capability_server_nodelet_manager_name set to the
name of the nodelet manager so that they may use
it to load their nodelet's into.
wjwwood added a commit that referenced this pull request Mar 8, 2014
added a builtin nodelet manager to the server
@wjwwood wjwwood merged commit 6021e86 into master Mar 8, 2014
@wjwwood wjwwood deleted the issue_42 branch March 8, 2014 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Redesign nodelet support
2 participants