AO3-3471 Filter works per language on language_works_path

[ceithir]

Pull Request Checklist

• Have you read "How to write the perfect pull request"?
• Have you read the contributing guidelines?
• Have you added tests for any changed functionality?
• Have you added the Jira issue number as the first thing in your pull request title (e.g. AO3-1234 Fix thing)
• Do you have fewer than 5 pull requests already open? If not, please wait until they are reviewed and merged before creating new pull requests.

Issue

https://otwarchive.atlassian.net/browse/AO3-3471

Purpose

Filter per language using ElasticSearch; same general behavior as filtering using a tag

Testing Instructions

Go to /languages/en/works, /languages/de/works, /languages/fr/works, etc.
Check the works shown are indeed in the selected language

Note: These routes are currently disabled on staging and production, and I'm not exactly sure how. nginx configuration?

Credit

Ceithir (he/him)

[brianjaustin]

Summarising conversation from elsewhere: we do hardcode 404 the path for efficiency reasons. In particular

otwarchive/app/controllers/languages_controller.rb

Line 9 in bba3552

@works = @language.works.recent.visible.limit(ArchiveConfig.NUMBER_OF_ITEMS_VISIBLE_IN_DASHBOARD)

is not super great. For now, let's have show redirect to the /language/:short/works path (we'll need to check admin edits work as normal though).

[weeklies]

@brianjaustin Is this ready to merge or action is still needed?

[ceithir]

we'll need to check admin edits work as normal though

Updated it to return to the index /languages, since that was already what the create route was doing.

[brianjaustin]

@weeklies you're right, I put the wrong label. Thanks for the poke! I'll try to do another pass this evening (EST) but for now I changed to Coder Has Actioned Review

Edit: @ceithir it looks like there are some failing tests related to the change, would you mind taking a look?

[brianjaustin]

I think it would be more obvious that this route belongs to languages if we use the member block like

Suggested change

	resources :languages do
	resources :languages, except: [:show] do
	resources :works
	resources :admin_posts
	end
	get "/languages/:id", to: redirect("/languages/%{id}/works", status: 302)
	resources :languages, except: [:show] do
	resources :works
	resources :admin_posts
	member do
	get :show, to: redirect("/languages/%{id}/works", status: 302)
	end
	end

[ceithir]

Doesn't appear to work. Or more exactly, it works too well, changing all get routes on /languages to a redirect.

I would say the get "/languages/:id", to:is good enough as is? It's consistent with official documentation.

[brianjaustin]

Oh no, definitely don't want that! I'm definitely good with your version over a version that breaks other things 😂