🐛 Cache load_dag in PathFinder only #2518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Marigold
force-pushed
the
cache-load-dag-in-pathfinder-only
branch
2 times, most recently
from
aaec886 to
5d04152
Compare
Marigold
force-pushed
the
cache-load-dag-in-pathfinder-only
branch
from
5d04152 to
f56d8ae
Compare
pabloarosado
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I started caching results of function
load_dag. This might have caused problems (e.g. this issue #2517). It's safer to cache it only inPathFinderand not globally as the function is used by other functions, too.