Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Cache load_dag in PathFinder only #2518

Merged
merged 1 commit into from
Apr 11, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions etl/helpers.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
import tempfile
from collections.abc import Generator
from contextlib import contextmanager
from functools import cache
from pathlib import Path
from typing import Any, Dict, Iterable, Iterator, List, Literal, Optional, Union, cast
from urllib.parse import urljoin
Expand Down Expand Up @@ -377,6 +378,10 @@ class WrongStepName(ExceptionFromDocstring):
"""Wrong step name. If this step was in the dag, it should be corrected."""


# loading DAG can take up to 1 second, so cache it
load_dag_cached = cache(load_dag)


class PathFinder:
"""Helper object with naming conventions. It uses your module path (__file__) and
extracts from it commonly used attributes like channel / namespace / version / short_name or
Expand Down Expand Up @@ -414,9 +419,9 @@ def dag(self):
"""Lazy loading of DAG."""
if self._dag is None:
if "/archive/" in str(self.f):
self._dag = load_dag(paths.DAG_ARCHIVE_FILE)
self._dag = load_dag_cached(paths.DAG_ARCHIVE_FILE)
else:
self._dag = load_dag()
self._dag = load_dag_cached()
return self._dag

@property
Expand Down
2 changes: 0 additions & 2 deletions etl/steps/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@
from collections import defaultdict
from concurrent.futures import ThreadPoolExecutor, as_completed
from dataclasses import dataclass, field
from functools import cache
from glob import glob
from importlib import import_module
from pathlib import Path
Expand Down Expand Up @@ -131,7 +130,6 @@ def traverse(graph: Graph, nodes: Set[str]) -> Graph:
return dict(reachable)


@cache
def load_dag(filename: Union[str, Path] = paths.DEFAULT_DAG_FILE) -> Dict[str, Any]:
return _load_dag(filename, {})

Expand Down
Loading