Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎉 make tags editable on the DI index page #4556

Open
wants to merge 4 commits into
base: create-di
Choose a base branch
from

Conversation

@owidbot
Copy link
Contributor

owidbot commented Feb 13, 2025

Quick links (staging server):

Site Dev Site Preview Admin Wizard Docs

Login: ssh owid@staging-site-di-index-page-tags

SVG tester:

Number of differences (default views): 0 ✅
Number of differences (all views): 0 ✅

Edited: 2025-02-13 15:08:13 UTC
Execution time: 1.20 seconds

Copy link
Member

@ikesau ikesau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! A super tight squeeze in the UI, but worth it for this new functionality!

If you get any spare time near the end of this cycle, one more filter on tags would maybe be useful 🙂

adminSiteClient/DataInsightIndexPage.tsx Outdated Show resolved Hide resolved
@sophiamersmann
Copy link
Member Author

Added the extra filter in a separate PR 👌🏻

I also excluded non-topic tags from the available tags since my understanding is that DIs should be tagged with topic tags.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
staging-viz Let SVG tester fail silently in CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants