🎉 add topic tags input to di creation dialog #4570
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 18, 2025
|
Quick links (staging server):
Login:
SVG tester:Number of differences (default views): 0 ✅ Edited: 2025-02-18 11:47:01 UTC |
sophiamersmann
force-pushed
the
chart-refs-di
branch
from
01c010a to
23a05bb
Compare
sophiamersmann
force-pushed
the
create-di-topic-tags
branch
from
55f09da to
b8da097
Compare
sophiamersmann
force-pushed
the
chart-refs-di
branch
from
23a05bb to
08bf0c4
Compare
sophiamersmann
force-pushed
the
create-di-topic-tags
branch
from
b8da097 to
7d78a3e
Compare
ikesau
approved these changes
Feb 20, 2025
| {topicTags.map((tag, index) => ( | ||
| <Fragment key={tag.id}> | ||
| <i>{tag.name}</i> | ||
| {index < topicTags.length - 1 && " and "} |
There was a problem hiding this comment.
I'm surprised we don't already have a util called englishJoin or something for this
| type FormData = Partial<Record<FormFieldName, string>> | ||
| type FormData = Partial< | ||
| Omit<Record<FormFieldName, string>, "topicTagIds"> & { | ||
| topicTagIds?: number[] |
There was a problem hiding this comment.
always so sad when you have to do something like this 😢
ikesau
reviewed
Feb 20, 2025
| <Select | ||
| placeholder="Select topic tags..." | ||
| mode="multiple" | ||
| showSearch |
There was a problem hiding this comment.
Oops, looks like this isn't working
di.wizard.tag.search.not.working.mov
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I forgot about topic tags!
This PR adds support for tagging DIs on creation in the admin.
This is part 8 of 9 in a stack made with GitButler: