Provide extended attributes when the event is emitted #518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phil-davis
force-pushed
the
add-extended-attributes-2022
branch
from
e1e3041
to
c742aef
Compare
phil-davis
commented
Sep 9, 2022
Provide extended attributes when the event is emitted. Signed-off-by: Sujith H <[email protected]>
phil-davis
force-pushed
the
add-extended-attributes-2022
branch
from
c034d63
to
644269a
Compare
|
This is needed to go with the core code in |
This was referenced Sep 9, 2022
|
Thanks, we did a guests 0.11.0 recently, and apparently this was missing. Once merged, I'll prepare guests 0.12.0 with minversion 10.11 to be bundled with core 10.11.0-rc.2 |
This was referenced Sep 9, 2022
AlexAndBear
requested changes
Sep 9, 2022
|
This is code written by someone else some time ago, and just rebased by me. |
AlexAndBear
requested changes
Sep 9, 2022
|
Kudos, SonarCloud Quality Gate passed! |
AlexAndBear
approved these changes
Sep 9, 2022
This was referenced Sep 10, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Provide extended attributes when the event is emitted.
Signed-off-by: Sujith H [email protected]
Rebase of #371
Related Issue
#516
How Has This Been Tested?
Manually set the apps whitelist in guests to include and exclude each of
And check that the corresponding functionality in the classic webUI is not displayed for a guest user when the app is not whitelisted.
Types of changes
Checklist: