Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PIN 5554 eservice isDelegable #1188

Open
wants to merge 13 commits into
base: feature/incaricato
Choose a base branch
from

Conversation

MalpenZibo
Copy link
Collaborator

@MalpenZibo MalpenZibo commented Nov 11, 2024

Closes PIN-5554

This PR:

  • adds the isDelegable flag on the service model
  • add the ability to get/create/modify this flag using the existing eservice endpoints

The ability to change this flag on published events will be implemented in this task https://pagopa.atlassian.net/browse/PIN-5700

Manual Test

Create eservice

image
image

Update Draft

image
image

Get eservice descriptor

image

Get producer eservice

image

Get producer eservice descriptor

image

API GW Get Eservice

image

@MalpenZibo MalpenZibo changed the title PIN 5554 Feature/eservice isDelegable PIN 5554 eservice isDelegable Nov 11, 2024
@MalpenZibo MalpenZibo force-pushed the feature/eservice-isdelegable-PIN-5554 branch from 9ea2f01 to a8eff9f Compare November 12, 2024 16:03
@MalpenZibo MalpenZibo force-pushed the feature/eservice-isdelegable-PIN-5554 branch from 7e63dcc to 1bf21ef Compare November 12, 2024 17:12
Copy link
Collaborator

@ecamellini ecamellini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments about BFF routes where we should add the flag + some other minor things

packages/api-clients/open-api/bffApi.yml Outdated Show resolved Hide resolved
packages/catalog-process/test/createEService.test.ts Outdated Show resolved Hide resolved
packages/models/src/eservice/protobufConverterToV2.ts Outdated Show resolved Hide resolved
@MalpenZibo MalpenZibo force-pushed the feature/eservice-isdelegable-PIN-5554 branch from 2dad452 to 242a9f2 Compare November 18, 2024 10:25
@MalpenZibo MalpenZibo force-pushed the feature/eservice-isdelegable-PIN-5554 branch from 242a9f2 to 38e56fe Compare November 18, 2024 10:44
Copy link
Collaborator

@ecamellini ecamellini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Three things are still missing IMO:

  • Adding the flag into the various read calls in BFF and API GW (only the ones that don't return compact data)
  • Adding the flag into the eservice import/export in BFF (see fileUtils.ts)
  • Updating the corresponding Bruno calls, performing some manual tests, and adding some test screenshots to the PR

You can use #1109 as a reference for all the points, where I did the same for the isSignalHubEnabled flag. I would do these things into the same PR so that it becomes another good reference on how to add a new field into a model in the future

@MalpenZibo MalpenZibo force-pushed the feature/eservice-isdelegable-PIN-5554 branch from e4b8708 to 633f044 Compare November 19, 2024 15:13
Copy link
Collaborator

@ecamellini ecamellini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants