-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PIN 5554 eservice isDelegable #1188
base: feature/incaricato
Are you sure you want to change the base?
PIN 5554 eservice isDelegable #1188
Conversation
ffee648
to
0f7ec96
Compare
9ea2f01
to
a8eff9f
Compare
7e63dcc
to
1bf21ef
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments about BFF routes where we should add the flag + some other minor things
2dad452
to
242a9f2
Compare
242a9f2
to
38e56fe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Three things are still missing IMO:
- Adding the flag into the various read calls in BFF and API GW (only the ones that don't return compact data)
- Adding the flag into the eservice import/export in BFF (see fileUtils.ts)
- Updating the corresponding Bruno calls, performing some manual tests, and adding some test screenshots to the PR
You can use #1109 as a reference for all the points, where I did the same for the isSignalHubEnabled
flag. I would do these things into the same PR so that it becomes another good reference on how to add a new field into a model in the future
e4b8708
to
633f044
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Closes PIN-5554
This PR:
The ability to change this flag on published events will be implemented in this task https://pagopa.atlassian.net/browse/PIN-5700
Manual Test
Create eservice
Update Draft
Get eservice descriptor
Get producer eservice
Get producer eservice descriptor
API GW Get Eservice