Remove DefaultLocale in favor of StringCaseLocaleUsage #2589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkoenig10
commented
Jun 6, 2023
Comment on lines
-136
to
-138
| // StringCaseLocaleUsage duplicates our existing DefaultLocale check which is already | ||
| // enforced in some places. | ||
| "StringCaseLocaleUsage", |
There was a problem hiding this comment.
This effectively changes this check from SUGGESTION to WARNING, but we've had an excavator for this for a while now, so this should be acceptable.
Comment on lines
-136
to
-138
| // StringCaseLocaleUsage duplicates our existing DefaultLocale check which is already | ||
| // enforced in some places. | ||
| "StringCaseLocaleUsage", |
There was a problem hiding this comment.
I see 5 references to DefaultLocale in our repos:
- 3 are increasing the severity to
WARNINGorERROR, so this change is fine for those repos - 2 are disabling this check, so those 2 repos will need to replace
DefaultLocalewithStringCaseLocaleUsage
There was a problem hiding this comment.
so this change is fine for those repos
I believe compilation will fail because no check exists with name DefaultLocale after this PR merges
There was a problem hiding this comment.
Here are the PRs for 2 of those 3. I'll also put up a PR for the one internal repo:
- Remove DefaultLocale override atlasdb#6605 (AtlasDB's baseline upgrade is blocked on other manual changes anyways)
- Remove DefaultLocale override dialogue#1946
This was referenced Jun 6, 2023
|
@carterkozak this should be good to merge now |
|
@carterkozak any other concerns here? |
|
Closing in favor of #2839 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This check is now provided by Error Prone, so we no longer need our custom
DefaultLocalecheck.