Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove DefaultLocale in favor of StringCaseLocaleUsage #2589

Closed
wants to merge 1 commit into from
Closed

Remove DefaultLocale in favor of StringCaseLocaleUsage #2589

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
64 changes: 0 additions & 64 deletions baseline-error-prone/src/main/java/com/palantir/baseline/errorprone/DefaultLocale.java
View file
Open in desktop

This file was deleted.

66 changes: 0 additions & 66 deletions baseline-error-prone/src/test/java/com/palantir/baseline/errorprone/DefaultLocaleTest.java
View file
Open in desktop

This file was deleted.

3 changes: 0 additions & 3 deletions gradle-baseline-java/src/main/groovy/com/palantir/baseline/plugins/BaselineErrorProne.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,9 +133,6 @@ private static void configureErrorProneOptions(
"CanIgnoreReturnValueSuggester",
"InlineMeSuggester",
"PreferImmutableStreamExCollections",
// StringCaseLocaleUsage duplicates our existing DefaultLocale check which is already
// enforced in some places.
"StringCaseLocaleUsage",
Comment on lines -136 to -138
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This effectively changes this check from SUGGESTION to WARNING, but we've had an excavator for this for a while now, so this should be acceptable.

Comment on lines -136 to -138
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see 5 references to DefaultLocale in our repos:

  • 3 are increasing the severity to WARNING or ERROR, so this change is fine for those repos
  • 2 are disabling this check, so those 2 repos will need to replace DefaultLocale with StringCaseLocaleUsage

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so this change is fine for those repos

I believe compilation will fail because no check exists with name DefaultLocale after this PR merges

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here are the PRs for 2 of those 3. I'll also put up a PR for the one internal repo:

"UnnecessaryTestMethodPrefix",
"UnusedVariable",
// See VarUsage: The var keyword results in illegible code in most cases and should not be used.
Expand Down