Split foundry-config-json package #1054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tzyl
commented
Dec 11, 2024
| @@ -865,7 +865,7 @@ importers: | |||
| version: 8.15.0([email protected]([email protected]))([email protected]) | |||
| '@vitejs/plugin-react': | |||
| specifier: ^4.2.0 | |||
| version: 4.2.1([email protected](@types/[email protected].1)([email protected])([email protected])) | |||
| version: 4.2.1([email protected](@types/[email protected].2)([email protected])([email protected])) | |||
There was a problem hiding this comment.
Hmm, not sure why the pnpm diff is so large and bumped @types/node everywhere
rosscourt
previously approved these changes
Dec 11, 2024
Base automatically changed from
tl/auto-version-package-json-strategy
to
main
December 12, 2024 10:13
tzyl
force-pushed
the
tl/split-foundry-config-json
branch
from
39cabf7 to
780ad87
Compare
policy-bot
bot
dismissed
rosscourt’s stale review
Invalidated by push of 780ad87
rosscourt
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on top of #1052
In order to use
foundry.config.jsonand auto version strategies in both@osdk/cliand@osdk/widget-manifest-vite-plugin, split out@osdk/foundry-config-json