feat: Support SettleAndMintRefund in periphery #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chefburger
reviewed
Mar 25, 2024
There was a problem hiding this comment.
Checked, oz version keeps 4.9.x
chefburger
reviewed
Mar 25, 2024
| @@ -10,7 +10,7 @@ | |||
| "test": "forge test", | |||
| "dev": "forge test -vvv -w", | |||
| "snapshot": "rm -fr .forge-snapshots && forge test", | |||
| "prettier": "forge fmt contracts/ && forge fmt test/ && forge fmt script/", | |||
| "prettier": "forge fmt src/ && forge fmt test/ && forge fmt script/", | |||
ChefMist
approved these changes
Mar 25, 2024
There was a problem hiding this comment.
for swap case. msgSender will get the minted the excess token.
for bin case
-> add liquidity: sender get minted excess token
-> remove liquidity: recipient get minted excess token
for nfp case:
-> mint: sender get minted excess token
-> increase liquidity: sender get minted excess token
-> decrease liquidity: sender get minted excess token
not a biggie in my opinion that recipient is the one getting minted excess token in bin case. objective of this is to deal with someone sending extra token to the vault and settle() fail. created pancakeswap/pancake-v4-periphery#4 just for us to track
This was referenced Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.