Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add changes from actions-rs-plus/clippy-check #6

Merged
merged 4 commits into from
Dec 13, 2022

Conversation

gbhand
Copy link
Collaborator

@gbhand gbhand commented Dec 9, 2022

Background

actions-rs/clippy-check (the base of this fork) is unmaintained.

actions-rs-plus/clippy-check is an up-to-date fork of it with proper Node 16 support, improved CI, and some code improvements. This repo should be update to be even with the new fork, then we should apply our feature-specific changes.

Description

Verification

This fork has been tested as a drop-in replacement for the previous version of clippy-check and successfully generates lints with annotations.

@gbhand gbhand self-assigned this Dec 9, 2022
@gbhand gbhand added the enhancement New feature or request label Dec 9, 2022
@gbhand gbhand requested a review from joshparallel December 9, 2022 21:41
@gbhand gbhand marked this pull request as ready for review December 9, 2022 21:41
@joshparallel
Copy link

So this won't affect monorail since we have a specific commit pinned? We're not just pointing to the main branch?

@gbhand
Copy link
Collaborator Author

gbhand commented Dec 9, 2022

So this won't affect monorail since we have a specific commit pinned? We're not just pointing to the main branch?

Correct @joshparallel . We pin all actions via SHA so commits to main don't affect dependers until they manually change their SHA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants