Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update prometheus binding failure logging format #6979

Conversation

liuchengxu
Copy link
Contributor

Using {:#?} for the error details is a bit annoying, this change makes a more consistent formatting style for error messages.

The output of `{:#?}` for the error details is a bit of annoying,
this change makes a more consistent formatting style for error messages.
Copy link
Member

@bkchr bkchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Next time adding an example of the output would be nice!

substrate/utils/prometheus/src/lib.rs Outdated Show resolved Hide resolved
@bkchr
Copy link
Member

bkchr commented Dec 22, 2024

/cmd prdoc --audience node_dev --bump patch

@bkchr bkchr added the T0-node This PR/Issue is related to the topic “node”. label Dec 22, 2024
@bkchr bkchr requested a review from skunert December 22, 2024 21:40
@bkchr bkchr enabled auto-merge December 22, 2024 21:40
@bkchr bkchr added this pull request to the merge queue Dec 23, 2024
Merged via the queue into paritytech:master with commit ca78179 Dec 23, 2024
198 of 201 checks passed
@liuchengxu liuchengxu deleted the update-prometheus-binding-failure-logging-format branch December 23, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T0-node This PR/Issue is related to the topic “node”.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants