Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update prometheus binding failure logging format #6979

Merged
merged 4 commits into from
Dec 23, 2024
Merged

Update prometheus binding failure logging format #6979

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cfb7bdc
Update prometheus binding failure logging format
liuchengxu Dec 22, 2024
7d0dffa
Update substrate/utils/prometheus/src/lib.rs
bkchr Dec 22, 2024
a2f3e40
Update from bkchr running command 'prdoc --audience node_dev --bump p…
Dec 22, 2024
a326de0
Merge branch 'master' into update-prometheus-binding-failure-logging-…
skunert Dec 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions prdoc/pr_6979.prdoc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
title: Update prometheus binding failure logging format
doc:
- audience: Node Dev
description: |-
Using `{:#?}` for the error details is a bit annoying, this change makes a more consistent formatting style for error messages.
crates:
- name: substrate-prometheus-endpoint
bump: patch
2 changes: 1 addition & 1 deletion substrate/utils/prometheus/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ async fn request_metrics(
/// to serve metrics.
pub async fn init_prometheus(prometheus_addr: SocketAddr, registry: Registry) -> Result<(), Error> {
let listener = tokio::net::TcpListener::bind(&prometheus_addr).await.map_err(|e| {
log::error!(target: "prometheus", "Error binding to '{:#?}': {:#?}", prometheus_addr, e);
log::error!(target: "prometheus", "Error binding to '{prometheus_addr:?}': {e:?}");
Error::PortInUse(prometheus_addr)
})?;

Expand Down
Loading