Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(design-guidelines): Adds guidance for actions in toolbars. #4026

Merged
merged 17 commits into from
Jul 16, 2024
Merged

docs(design-guidelines): Adds guidance for actions in toolbars. #4026

merged 17 commits into from
Jul 16, 2024

Conversation

edonehoo
Copy link
Collaborator

@edonehoo edonehoo commented May 15, 2024 •
edited
Loading

Closes #3985 and #3973

Note: I linked to a currently-non-existent, but coming-soon page for a higher level actions pattern, which will be covered by #3986.

@edonehoo edonehoo self-assigned this May 15, 2024
@edonehoo edonehoo marked this pull request as draft May 15, 2024 14:53
@patternfly-build
Copy link
Contributor

patternfly-build commented May 15, 2024 •
edited
Loading

Preview: https://patternfly-org-pr-4026-site.surge.sh

@edonehoo edonehoo marked this pull request as ready for review May 29, 2024 13:15
@edonehoo edonehoo requested a review from mmenestr May 29, 2024 16:54
mmenestr
mmenestr requested changes Jun 4, 2024
View reviewed changes
Copy link
Collaborator

@mmenestr mmenestr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a couple comments but looks great overall!!

@edonehoo edonehoo requested a review from mmenestr June 6, 2024 13:03
@edonehoo edonehoo requested a review from mmenestr June 26, 2024 20:17
@edonehoo
Copy link
Collaborator Author

@mmenestr okay this is ready for another review!!

@nicolethoen nicolethoen linked an issue Jun 28, 2024 that may be closed by this pull request
Table and/or Cards - Clarify use of actions in toolbar #3973
Closed
mmenestr
mmenestr reviewed Jul 2, 2024
View reviewed changes
...entation-site/patternfly-docs/content/design-guidelines/components/table/img/page-action.png Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You forgot to remove the kebab at the header level of the table!
Also for the page-wide actions button, I would either make it a dropdown, or make it singular - since it's just one action, not multiple page-wide actions.

Copy link
Collaborator Author

@edonehoo edonehoo Jul 3, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ohhh I totally misunderstood the kebab header previously. I'll update this image in both prs again, ty!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you're gonna kill me but I just noticed one more thing which is that if you're going to have a selected item in the table, the bulk select at the header level has to be in the "mixed" state, not the unselected state haha

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ahahha no, ty I really appreciate the suggestions, because you have great insight into the actual design patterns!

@mmenestr mmenestr self-requested a review July 11, 2024 18:34
mmenestr
mmenestr approved these changes Jul 11, 2024
View reviewed changes
Copy link
Collaborator

@mmenestr mmenestr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nicolethoen nicolethoen merged commit 0dc9b50 into patternfly:main Jul 16, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmenestr mmenestr mmenestr approved these changes

Assignees

@edonehoo edonehoo

Labels
Content
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve guidance around actions in toolbars Table and/or Cards - Clarify use of actions in toolbar
4 participants
@edonehoo @patternfly-build @mmenestr @nicolethoen