Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(design-guidelines): Adds guidance for actions in toolbars. #4026
docs(design-guidelines): Adds guidance for actions in toolbars. #4026
Changes from 5 commits
87dfd94
459f95d
4b9166a
7452462
7c47456
4d72e43
67434ec
ddbd472
c8f8f0c
db0f2dc
04260dd
1cdf9d8
93d5d4c
3ae474c
871872b
7c13495
e8f1567
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You forgot to remove the kebab at the header level of the table!
Also for the page-wide actions button, I would either make it a dropdown, or make it singular - since it's just one action, not multiple page-wide actions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ohhh I totally misunderstood the kebab header previously. I'll update this image in both prs again, ty!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you're gonna kill me but I just noticed one more thing which is that if you're going to have a selected item in the table, the bulk select at the header level has to be in the "mixed" state, not the unselected state haha
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ahahha no, ty I really appreciate the suggestions, because you have great insight into the actual design patterns!