Update notes for react-charts #793
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlabrecq
changed the title
dlabrecq
changed the title
dlabaj
approved these changes
Oct 23, 2024
| @@ -2,7 +2,9 @@ | |||
|
|
|||
| In order to support multiple chart libraries, Victory based charts have moved. This rule will update import paths to our victory directory. | |||
|
|
|||
| Additionally, Victory has become a peer dependency. | |||
| Additionally, Victory is now an optional peer dependency, allowing future chart libraries to be installed without including Victory dependencies and vice versa | |||
There was a problem hiding this comment.
Org's upgrade section has been updated already. This PR syncs with that info
thatblindgeye
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update notes to describe Victory as an optional peer dependency
patternfly/patternfly-react#11125