Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update notes for react-charts #793

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update notes for react-charts #793

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .../eslint-plugin-pf-codemods/src/rules/v6/chartsImportMoved/chartsImport-moved.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,9 @@

In order to support multiple chart libraries, Victory based charts have moved. This rule will update import paths to our victory directory.

Additionally, Victory has become a peer dependency.
Additionally, Victory is now an optional peer dependency, allowing future chart libraries to be installed without including Victory dependencies and vice versa
Copy link

@dlabaj dlabaj Oct 23, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kmcfaul @edonehoo Do we need this information in the upgrade section on org for people upgrading to v6?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Org's upgrade section has been updated already. This PR syncs with that info


You may choose to install the single "victory" package to cover all features. Or, install packages based on the features used in your app (e.g., "victory-core", "victory-tooltip", etc.).

#### Examples

Expand Down
4 changes: 3 additions & 1 deletion packages/pf-codemods/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -372,7 +372,9 @@ export const CardUpdatedClickableMarkupInput = () => {

In order to support multiple chart libraries, Victory based charts have moved. This rule will update import paths to our victory directory.

Additionally, Victory has become a peer dependency.
Additionally, Victory is now an optional peer dependency, allowing future chart libraries to be installed without including Victory dependencies and vice versa

You may choose to install the single "victory" package to cover all features. Or, install packages based on the features used in your app (e.g., "victory-core", "victory-tooltip", etc.).

#### Examples

Expand Down
Loading