Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pyreadline3 instead of pyreadline #44

Closed
wants to merge 1 commit into from

Conversation

Andrej730
Copy link

@Andrej730 Andrej730 commented Feb 7, 2023

Based on #41

Let's replace abandonded pyreadline with pyreadline3. As said in #41 it will fix #36 and #37.

@athrvvvv @blueyed

Copy link

@athrvvvv athrvvvv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@Andrej730
Copy link
Author

Andrej730 commented Mar 7, 2023

@athrvvvv @blueyed any changes still needed for merge?

@athrvvvv
Copy link

athrvvvv commented Mar 7, 2023

@athrvvvv @blueyed any changes still needed for merge?

Actually, one of the contributor must approve the changes of the checks, once it is done you PR will be merged 🫶

Also one suggestion, I don't think so the project is active anymore and if there, they must not feel that this commit is important... so just move on dude 🤝🏻

@Andrej730
Copy link
Author

Andrej730 commented Mar 8, 2023

Actually, one of the contributor must approve the changes of the checks, once it is done you PR will be merged 🫶

Also one suggestion, I don't think so the project is active anymore and if there, they must not feel that this commit is important... so just move on dude 🤝🏻

Ikr... but this package seems really nice and I want to be able to recommend it to people easily.
But currently it's broken but the fix is right there, just need to accept it 🥲

@athrvvvv
Copy link

athrvvvv commented Mar 9, 2023

Ikr... but this package seems really nice and I want to be able to recommend it to people easily.
But currently it's broken but the fix is right there, just need to accept it 🥲

Actually the project is open-source, if you really want yo fix the package just fork it and release your own version 👍
But do tell me when the package is released 😌

@Andrej730
Copy link
Author

Andrej730 commented Mar 9, 2023

Actually the project is open-source, if you really want yo fix the package just fork it and release your own version 👍
But do tell me when the package is released 😌

You mean to release it as some fancycompleter2? Like what happened to pyreadline... twice.

@athrvvvv
Copy link

athrvvvv commented Mar 9, 2023

Actually the project is open-source, if you really want yo fix the package just fork it and release your own version 👍
But do tell me when the package is released 😌

You mean to release it as some fancycompleter2? Like what happened to pyreadline... twice.

yes.

@blueyed
Copy link
Collaborator

blueyed commented Mar 13, 2023

Same as #41, no? Closing.

Will comment there.

@blueyed blueyed closed this Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pyreadline doesn't work on Python 3.10
3 participants