Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pyreadline3 instead of pyreadline #44

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -101,8 +101,8 @@ By default, `fancycompleter` tries to use `pyrepl` if it finds it. To
get colors you need a recent version, \>= 0.8.2.

Starting from version 0.6.1, `fancycompleter` works also on **Windows**,
relying on [pyreadline](https://pypi.python.org/pypi/pyreadline). At the
moment of writing, the latest version of `pyreadline` is 2.1, which does
relying on [pyreadline3](https://pypi.python.org/pypi/pyreadline3). At the
moment of writing, the latest version of `pyreadline3` is 2.1, which does
**not** support colored completions; here is the [pull
request](https://github.com/pyreadline/pyreadline/pull/48) which adds
support for them. To enable colors, you can install `pyreadline` from
Expand Down
4 changes: 2 additions & 2 deletions fancycompleter.py
Original file line number Diff line number Diff line change
Expand Up @@ -150,8 +150,8 @@ def find_pyrepl(self):
def find_pyreadline(self):
try:
import readline
import pyreadline # noqa: F401 # XXX: needed really?
from pyreadline.modes import basemode
import pyreadline3 as pyreadline # noqa: F401 # XXX: needed really?
from pyreadline3.modes import basemode
except ImportError:
return None
if hasattr(basemode, 'stripcolor'):
Expand Down
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,6 @@
],
install_requires=[
"pyrepl @ git+https://github.com/pdbpp/pyrepl@master#egg=pyrepl",
"pyreadline;platform_system=='Windows'",
"pyreadline3;platform_system=='Windows'",
]
)