-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add dependency on pear-core-minimal #33
base: master
Are you sure you want to change the base?
Conversation
ps: i just noticed that pear-core-minimal is already in dev deps, but with a higher min version. I can amend this PR for that... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It will force everyone to install pear/pear-core-minimal
even if they have pear/pear
installed.
@sanmai you are right. This is why I think that, before merging this, some work needs to be done within the pear core packages, so that only one of either I have created an issue for that at pear/pear-core#142, but so far there has not been a lot of feedback... |
@@ -17,6 +17,7 @@ | |||
], | |||
"require": { | |||
"php": ">=5.6", | |||
"pear/pear-core-minimal": "^1.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you'll need to remove the minimal
entry in the dev
section.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will do
Are we sure |
Will test different scenarios, to determine what works best: whether specifying a minimum version of pear-core-minimal of 1.10.0 or 1.10.16 makes a difference, or whether that does not make any difference, but we still get double-installs when having pear/pear versions before 1.10.16)
|
I am not privy how PEAR is supposed to work when installed via Composer - whether packages such as this should depend on
pear-core
orpear-core-minimal
, but still atm the OLE package does not work when installed stand-alone via composer