Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add dependency on pear-core-minimal #33

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gggeek
Copy link

@gggeek gggeek commented Jul 26, 2024

I am not privy how PEAR is supposed to work when installed via Composer - whether packages such as this should depend on pear-core or pear-core-minimal, but still atm the OLE package does not work when installed stand-alone via composer

@gggeek
Copy link
Author

gggeek commented Jul 26, 2024

ps: i just noticed that pear-core-minimal is already in dev deps, but with a higher min version. I can amend this PR for that...

Copy link
Member

@sanmai sanmai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will force everyone to install pear/pear-core-minimal even if they have pear/pear installed.

@gggeek
Copy link
Author

gggeek commented Oct 12, 2024

@sanmai you are right.

This is why I think that, before merging this, some work needs to be done within the pear core packages, so that only one of either pear-core or pear-core gets installed.

I have created an issue for that at pear/pear-core#142, but so far there has not been a lot of feedback...

@@ -17,6 +17,7 @@
],
"require": {
"php": ">=5.6",
"pear/pear-core-minimal": "^1.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you'll need to remove the minimal entry in the dev section.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do

@ashnazg
Copy link
Member

ashnazg commented Nov 24, 2024

Are we sure minimal causing a hard requirement on core? The composer.json from pear-core has been listing a replace pear-core-minimal in it since 58bde0e in 2017. I've just added exception to that list in core today too.

@gggeek
Copy link
Author

gggeek commented Nov 25, 2024

Will test different scenarios, to determine what works best: whether specifying a minimum version of pear-core-minimal of 1.10.0 or 1.10.16 makes a difference, or whether that does not make any difference, but we still get double-installs when having pear/pear versions before 1.10.16)

  • with nothing else required(as in "required by the main project's composer.json")
  • with pear/pear required (>= 1.10.0)
  • with pear/pear required (>= 1.10.16)
  • with pear/pear_exception required
  • with both pear/pear and pear/pear_exception required

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants