Remove "macdeployqtfix" from our deployment script #1823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- No longer needed as the official deployment tool "macdeployqt" has been fixed in Qt5.15
scribblemaniac
approved these changes
Apr 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The use of
macdeployqtfixis no longer needed as the official Qt deployment toolmacdeployqtworks as expected.I carefully checked the Mac app bundles before and after applying
macdeployqtfix, and I didn't see any differences between the two. Therefore, it should be safe to removemacdeployqtfixfrom our deployment process.The only scenario where
macdeployqtfixmay be required is building the legacy Mac version, which is built with Qt 5.6 as far as I know.