image-android-sparse: make the CRC optional #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recent Android fastboot tools don't support sparse images containing the CRC at the end of the image and instead fail with an coredump. Checking the fastboot code base there are no promising commits that this will change in the near future: | commit 94d05063ba7d2a2d614733d179c4bce94cead362 | Author: Hridya Valsaraju <[email protected]> | Date: Tue Oct 2 10:08:38 2018 -0700 | | Remove tests for sparse images with CRC from fuzzy_fastboot | | Sparse images with CRC are currently not supported by the | Android build system. | | Test: ./fuzzy_fastboot --gtest_filter=Conformance.* | Change-Id: I6a73fb0dc5d4c77a3d1a0384c137789eb06fa956 Therefore make the crc optional and turn it of by default to have an better user experience. This is also what img2simg does except for the fact that they don't support adding the crc at all. Signed-off-by: Marco Felsch <[email protected]>
|
The test fails, probably because the CRC is now missing. Can you please enable the CRC for the existing test and create a new one without CRC. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent Android fastboot tools don't support sparse images containing the CRC at the end of the image and instead fail with an coredump. Checking the fastboot code base there are no promising commits that this will change in the near future:
| commit 94d05063ba7d2a2d614733d179c4bce94cead362
| Author: Hridya Valsaraju [email protected]
| Date: Tue Oct 2 10:08:38 2018 -0700
|
| Remove tests for sparse images with CRC from fuzzy_fastboot
|
| Sparse images with CRC are currently not supported by the
| Android build system.
|
| Test: ./fuzzy_fastboot --gtest_filter=Conformance.*
| Change-Id: I6a73fb0dc5d4c77a3d1a0384c137789eb06fa956
Therefore make the crc optional and turn it of by default to have an better user experience. This is also what img2simg does except for the fact that they don't support adding the crc at all.