Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

image-android-sparse: make the CRC optional #240

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Commits on Feb 26, 2024

  1. image-android-sparse: make the CRC optional

    Recent Android fastboot tools don't support sparse images containing the
    CRC at the end of the image and instead fail with an coredump. Checking
    the fastboot code base there are no promising commits that this will
    change in the near future:
    
    | commit 94d05063ba7d2a2d614733d179c4bce94cead362
    | Author: Hridya Valsaraju <[email protected]>
    | Date:   Tue Oct 2 10:08:38 2018 -0700
    |
    |     Remove tests for sparse images with CRC from fuzzy_fastboot
    |
    |     Sparse images with CRC are currently not supported by the
    |     Android build system.
    |
    |     Test: ./fuzzy_fastboot --gtest_filter=Conformance.*
    |     Change-Id: I6a73fb0dc5d4c77a3d1a0384c137789eb06fa956
    
    Therefore make the crc optional and turn it of by default to have an
    better user experience. This is also what img2simg does except for the
    fact that they don't support adding the crc at all.
    
    Signed-off-by: Marco Felsch <[email protected]>
    Marco Felsch committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    de1cba5 View commit details
    Browse the repository at this point in the history