Merge pull request ppy#30389 from bdach/fix-looping-samples-not-stopping

Fix old looping samples not stopping when replacing a `SkinnableSound`'s `Samples`
peppy · Oct 23, 2024 · c1453cf · c1453cf
2 parents b1b0aad + 1008d32
commit c1453cf
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/osu.Game/Skinning/SkinnableSound.cs b/osu.Game/Skinning/SkinnableSound.cs
@@ -154,6 +154,9 @@ private void updateSamples()
         {
             bool wasPlaying = IsPlaying;
 
+            if (wasPlaying && Looping)
+                Stop();
+
             // Remove all pooled samples (return them to the pool), and dispose the rest.
             samplesContainer.RemoveAll(s => s.IsInPool, false);
             samplesContainer.Clear();