fix: tests

* test-get_affiliation
* test-acronyms

The mix of warning and return value was causing a warning
in the test rather than a pass status. Also, latex was not installed
so the acronyms could not be tested.
Codecoverage needs all tests to be passing.

tests/testthat/setup.R

@@ -0,0 +1,12 @@
+# Setup for the unit tests
+
+# Check for lualatex
+if (!requireNamespace("tinytex", quietly = TRUE)) {
+  install.packages("tinytex")
+}
+if (any(tinytex:::which_bin(c("tlmgr", "pdftex", "xetex", "luatex")) == "")) {
+  tinytex::install_tinytex(bundle = "TinyTex")
+}
+if (!tinytex::check_installed("glossaries")) {
+  tinytex::tlmgr_install("glossaries")
+}

tests/testthat/test-acronyms.R

@@ -1,36 +1,38 @@
 test_that("Acronyms compile with hyperlink", {
-	file_glossaries <- system.file(
-		"rmarkdown", "templates", "sa", "skeleton", "sa4ss_glossaries.tex",
-		package = "sa4ss"
-	)
-	dir_build <- file.path(tempdir(), "sa4ss")
-	file_doc <- file.path(dir_build, "sa4ss_doc.tex")
-	dir.create(dir_build, showWarnings = FALSE)
-	file.copy(
-		file_glossaries,
-		file.path(dir_build, basename(file_glossaries)),
-		overwrite = TRUE
-	)
-	writeLines(
-		text = c(
-			"\\documentclass{report}",
-			"\\usepackage{glossaries}",
-			"\\usepackage[colorlinks]{hyperref}",
-			"\\makeglossaries",
-			"\\loadglsentries{sa4ss_glossaries.tex}",
-			"\\begin{document}",
-			"Some test text \\glsentrytext{mlml}.",
-			"\\printglossaries",
-			"\\end{document}"
-		),
-		con = file_doc
-	)
-	old_wd <- getwd()
-	on.exit(setwd(old_wd))
-	on.exit(unlink(dir_build, recursive = TRUE), add = TRUE)
-	setwd(dir_build)
-	end <- system(
-		paste("lualatex", basename(file_doc))
-	)
-	expect_equal(end, 0)
+  skip_on_os("linux", arch = NULL)
+  file_glossaries <- system.file(
+    "rmarkdown", "templates", "sa", "skeleton", "sa4ss_glossaries.tex",
+    package = "sa4ss"
+  )
+  dir_build <- file.path(tempdir(), "sa4ss")
+  file_doc <- file.path(dir_build, "sa4ss_doc.tex")
+  dir.create(dir_build, showWarnings = FALSE)
+  file.copy(
+    file_glossaries,
+    file.path(dir_build, basename(file_glossaries)),
+    overwrite = TRUE
+  )
+  writeLines(
+    text = c(
+      "\\documentclass{report}",
+      "\\usepackage{glossaries}",
+      "\\usepackage[colorlinks]{hyperref}",
+      "\\makeglossaries",
+      "\\loadglsentries{sa4ss_glossaries.tex}",
+      "\\begin{document}",
+      "Some test text \\glsentrytext{mlml}.",
+      "\\printglossaries",
+      "\\end{document}"
+    ),
+    con = file_doc
+  )
+  old_wd <- getwd()
+  on.exit(setwd(old_wd))
+  on.exit(unlink(dir_build, recursive = TRUE), add = TRUE)
+  setwd(dir_build)
+  end <- system2(
+    command = "lualatex",
+    args = paste(basename(file_doc))
+  )
+  expect_equal(end, 0)
 })

tests/testthat/test-get_affiliation.R

@@ -1,3 +1,8 @@
 test_that("Unknown author returns NA", {
-	expect_true(is.na(get_affiliation("Kelli Johnson")))
+  expect_warning(
+    is.na(get_affiliation("Kelli Johnson"))
+  )
+  expect_true(
+    suppressWarnings(is.na(get_affiliation("Kelli Johnson")))
+  )
 })

tests/testthat/test-session.R

@@ -1,5 +1,5 @@
 test_that("session_test is successful", {
-	test <- session_test()
+	test <- suppressWarnings(session_test())
 	expect_false(
 		inherits(test, "error")
 	)