New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix rendering explicit template in 1.1 #130

Merged

joeldrapper merged 2 commits into main from kbs/fix-render-template

Nov 27, 2023

Collaborator

joeldrapper commented Nov 27, 2023 •

edited

Loading

Originally opened as #125. This PR includes a small fix for older versions of Ruby.

Closes #125

Burgestrand and others added 2 commits

November 27, 2023 11:47


          Only pass a block to render if one was actually given

This call style/parameter is documented in e.g: https://guides.rubyonrails.org/layouts_and_rendering.html#rendering-an-action-s-template-from-another-controller

In b0cc8bc the code was changed from _only passing a block to render if one was originally given_ to _always passing a block to render regardless_. This is enough to break the call to render in some situations.

This change only passes a block to render if one was actually given to begin with.


          Update sgml_spec to be compatible with older versions of Ruby

0f43146

joeldrapper mentioned this pull request

Fix rendering explicit template in 1.1 #125

Closed

joeldrapper merged commit 4229e68 into main

11 checks passed

joeldrapper deleted the kbs/fix-render-template branch

November 27, 2023 13:48

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet