Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix rendering explicit template in 1.1 #130

Merged
merged 2 commits into from
Nov 27, 2023
Merged

Fix rendering explicit template in 1.1 #130

merged 2 commits into from
Nov 27, 2023

Commits on Nov 27, 2023

  1. Only pass a block to render if one was actually given 

    This call style/parameter is documented in e.g: https://guides.rubyonrails.org/layouts_and_rendering.html#rendering-an-action-s-template-from-another-controller

In b0cc8bc the code was changed from _only passing a block to render if one was originally given_ to _always passing a block to render regardless_. This is enough to break the call to render in some situations.

This change only passes a block to render if one was actually given to begin with.
    @Burgestrand
    Burgestrand committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    1456928 View commit details
    Browse the repository at this point in the history

  2. Update sgml_spec to be compatible with older versions of Ruby

    @joeldrapper
    joeldrapper committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    0f43146 View commit details
    Browse the repository at this point in the history