Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Normalize Expression for object returned by the api #3

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Add Normalize Expression for object returned by the api #3

wants to merge 7 commits into from

Conversation

JoMessina
Copy link

No description provided.

@JoMessina JoMessina requested review from gplanchat and sebprt October 17, 2023 12:24
@JoMessina JoMessina force-pushed the feature/Add-serializable-class-from-api branch from 18044af to 83c9d9f Compare October 19, 2023 08:35
@JoMessina JoMessina force-pushed the feature/Add-serializable-class-from-api branch from 83c9d9f to d989595 Compare October 19, 2023 08:36
@JoMessina
Copy link
Author

Après tous les changements subis, ce code est peut-être à destination d'un package comme string expression language, à confirmer.

sebprt
sebprt requested changes Oct 19, 2023
View reviewed changes
src/MagentoExpressionLanguageProvider.php Outdated Show resolved Hide resolved
@JoMessina JoMessina requested a review from sebprt October 20, 2023 07:41
@JoMessina JoMessina force-pushed the feature/Add-serializable-class-from-api branch from 24bd176 to 95fa9bd Compare October 20, 2023 07:42
@JoMessina JoMessina force-pushed the feature/Add-serializable-class-from-api branch from 95fa9bd to 8f84b2e Compare October 20, 2023 07:45
@JoMessina JoMessina force-pushed the feature/Add-serializable-class-from-api branch from 5d64754 to ee017ce Compare October 20, 2023 08:44
@JoMessina JoMessina changed the title Add serializable class for product model from Magento2 api client Add Normalize Expression for object returned by the api Oct 20, 2023
@JoMessina JoMessina added the GTM Good to merge label Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebprt sebprt sebprt approved these changes

@gplanchat gplanchat Awaiting requested review from gplanchat

Assignees
No one assigned
Labels
GTM Good to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JoMessina @gplanchat @sebprt