Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Normalize Expression for object returned by the api #3

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Add Normalize Expression for object returned by the api #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
5d2304b
Add interface and class serializable for models from Magento2 api client
JoMessina Oct 17, 2023
de6bacc
Use ReflectionObject to iterate an object on properties
JoMessina Oct 18, 2023
d989595
management of array with object
JoMessina Oct 18, 2023
1c4655b
Delete old class and interface we don't use anymore
JoMessina Oct 19, 2023
8f84b2e
rename class and expression names
JoMessina Oct 20, 2023
2b5aff6
update cs-fixer, add same rules we have on the distribution, and fix …
JoMessina Oct 20, 2023
ee017ce
remove magento2-api-client package, we don't use it anymore
JoMessina Oct 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/quality.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,9 @@ jobs:
- uses: actions/checkout@v2
- name: Cs-Fixer
run: |
wget -q https://cs.symfony.com/download/php-cs-fixer-v2.phar -O php-cs-fixer
wget -q https://cs.symfony.com/download/php-cs-fixer-v3.phar -O php-cs-fixer
chmod a+x php-cs-fixer
PHP_CS_FIXER_IGNORE_ENV=true ./php-cs-fixer fix src --dry-run
./php-cs-fixer fix src --dry-run
JoMessina marked this conversation as resolved.
Show resolved Hide resolved

phpstan:
runs-on: ubuntu-latest
Expand Down
41 changes: 41 additions & 0 deletions .php-cs-fixer.dist.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,41 @@
<?php

$finder = (new PhpCsFixer\Finder())
->in('src')
;

return (new PhpCsFixer\Config())
->setRiskyAllowed(true)
->setRules([
'@PHP82Migration' => true,
'@PHP81Migration' => true,
'@PHP80Migration:risky' => true,
'@PHPUnit84Migration:risky' => true,
'@PSR1' => true,
'@PSR12' => true,
'@PhpCsFixer' => true,
'@Symfony' => true,
'ternary_to_elvis_operator' => true,
'set_type_to_cast' => true,
'self_accessor' => true,
'psr_autoloading' => true,
'php_unit_test_annotation' => ['style' => 'annotation'],
'php_unit_set_up_tear_down_visibility' => true,
'php_unit_construct' => true,
'no_useless_sprintf' => true,
'no_homoglyph_names' => true,
'native_function_invocation' => true,
'native_constant_invocation' => true,
'modernize_types_casting' => true,
'logical_operators' => true,
'is_null' => true,
'function_to_constant' => true,
'fopen_flag_order' => true,
'error_suppression' => true,
'ereg_to_preg' => true,
'dir_constant' => true,
'method_chaining_indentation' => false,
])
->setFinder($finder)
->setCacheFile('.php-cs-fixer.cache') // forward compatibility with 3.x line
;
5 changes: 4 additions & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,10 @@
"symfony/expression-language": "^6.0"
},
"config": {
"bin-dir": "bin"
"bin-dir": "bin",
"allow-plugins": {
"php-http/discovery": true
}
},
"extra": {
"branch-alias": {
Expand Down
Loading
Loading