add system variable back for tidb_enable_point_get_plan_cache. #20679
Conversation
ti-chi-bot
bot
added
missing-translation-status
AilinKid
changed the title
|
@qw4990: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/gemini review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
The pull request reintroduces the tidb_enable_point_get_cache system variable documentation. The change seems straightforward, but I've added a comment to ensure the description is comprehensive.
Merge Readiness
The pull request appears ready for merging, pending resolution of the minor documentation suggestion. I am unable to directly approve the pull request, and recommend that others review and approve this code before merging.
hfxsd
added
translation/from-docs-cn
|
/bot-review |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
✅ AI review completed, 1 comments generated. |
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: xixirangrang <hfxsd@hotmail.com>
hfxsd
added
the
needs-cherry-pick-release-8.5
Co-authored-by: xixirangrang <hfxsd@hotmail.com>
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
[LGTM Timeline notifier]Timeline:
|
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hfxsd The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
In response to a cherrypick label: new pull request created to branch |
First-time contributors' checklist
What is changed, added or deleted? (Required)
after fix of pingcap/tidb#60272, we add tidb_enable_point_get_cache back, so we just add the variable document back
Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions.
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?