add system variable back for tidb_enable_point_get_plan_cache. (#20679) #20723
Conversation
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: xixirangrang <hfxsd@hotmail.com>
Co-authored-by: xixirangrang <hfxsd@hotmail.com>
ti-chi-bot
added
lgtm
size/XS
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hello @ti-chi-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
Summary of Changes
This pull request is a cherry-pick of #20679 and reintroduces the documentation for the tidb_enable_point_get_cache system variable. This variable was added back after the fix in pingcap/tidb#60272. The change involves adding a section to the system-variables.md file describing the variable's scope, applicability to hints, type, default value, and usage.
Highlights
- Documentation: Reintroduces documentation for the
tidb_enable_point_get_cachesystem variable. - System Variable: Describes the
tidb_enable_point_get_cachevariable, which enables caching of point query results when the table lock type is set toREAD.
Changelog
- system-variables.md
- Added documentation for the
tidb_enable_point_get_cachesystem variable, including its scope (SESSION), applicability to hints (SET_VAR), type (Boolean), default value (OFF), and a description of its function.
- Added documentation for the
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
A cache to speed,
Point gets, a welcome deed,
Queries now take flight.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
The pull request reintroduces the tidb_enable_point_get_cache system variable documentation. The changes look straightforward and necessary to align the documentation with the code. I have a minor suggestion regarding the description of the variable.
Merge Readiness
The pull request seems ready to be merged after addressing the minor suggestion. I am unable to directly approve the pull request, and recommend that others review and approve this code before merging.
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hfxsd The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This is an automated cherry-pick of #20679
First-time contributors' checklist
What is changed, added or deleted? (Required)
after fix of pingcap/tidb#60272, we add tidb_enable_point_get_cache back, so we just add the variable document back
Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions.
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?