Update running-pinot-in-docker.md to include minion config #397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NihalJain
reviewed
Dec 5, 2024
| @@ -319,6 +319,16 @@ services: | |||
| retries: 5 | |||
| start_period: 10s | |||
|
|
|||
| pinot-minion: | |||
| image: ${PINOT_IMAGE:-apachepinot/pinot:1.2.0} | |||
| command: "StartMinion -zkAddress zookeeper-houseprices:2181" | |||
There was a problem hiding this comment.
- Do you mean pinot-zookeeper:2181? Is this docker compose file tested?
- Could we add ports?
- Can you also update relevant services which start up i.e.
docker container lsoutput? - Also consider adding how to start minion via docker run in the section above docker compose section?
There was a problem hiding this comment.
@NihalJain I have made all the suggested changes and tested the docker compose file. Please review
1. updated the correct zookeeper address in Minion in docker compose. 2. Added docker run command for minion 3. Added minion container in docker container ls output 4. added minion ports in docker-compose file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.